Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-12-01 #17271

Merged
merged 12 commits into from
Jan 20, 2022
Merged

[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-12-01 #17271

merged 12 commits into from
Jan 20, 2022

Conversation

arpja
Copy link
Contributor

@arpja arpja commented Jan 6, 2022 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @arpja Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 6, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️LintDiff: 4 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R4021 - DescriptionAndTitleMissing 'policyType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L5497
    ⚠️ R4021 - DescriptionAndTitleMissing 'DailySchedule' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6966
    ⚠️ R4021 - DescriptionAndTitleMissing 'WeeklySchedule' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6979
    ⚠️ R4021 - DescriptionAndTitleMissing 'scheduleRunDays' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6982


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig'
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L21
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupPreValidateProtection'
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L164
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupStatus'
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L209
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupValidateFeatures'
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L254
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/backupProtectionIntent/{intentObjectName}'
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L299
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupProtectionIntents'
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L460
    ❌ R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupUsageSummaries'
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L517
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'BackupResourceStorageConfigsNonCRR_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L22
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ProtectionIntent_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L300
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'BackupResourceVaultConfigs_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L609
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'BackupResourceEncryptionConfigs_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L758
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnection_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L852
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ProtectedItems_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L1298
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ProtectedItemOperationResults_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L1521
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'RecoveryPoints_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L1677
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ProtectionPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L1907
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ProtectionPolicyOperationResults_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L2093
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'JobDetails_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L2221
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'BackupEngines_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L2834
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ProtectionContainers_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L3022
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ProtectionContainerOperationResults_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L3352
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ResourceGuardProxy_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4313
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'BackupResourceStorageConfigsNonCRR_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L65
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ProtectionIntent_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L351
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'BackupResourceVaultConfigs_Put' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L704
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnection_Put' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L902
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ProtectedItems_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L1373
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ProtectionPolicies_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L1960
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ProtectionContainers_Register' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L3079
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'ResourceGuardProxy_Put' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4362
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 42 Errors, 29 Warnings failed [Detail]
    The following breaking changes are detected by comparison with the latest stable version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupUsageSummaries' removed or restructured?
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L21:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupAadProperties' removed or restructured?
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L87:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupCrossRegionRestore' removed or restructured?
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L137:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupCrrJob' removed or restructured?
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L195:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupCrrJobs' removed or restructured?
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L246:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupCrrOperationResults/{operationId}' removed or restructured?
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L315:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.RecoveryServices/locations/{azureRegion}/backupCrrOperationsStatus/{operationId}' removed or restructured?
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L362:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/recoveryPoints/{recoveryPointId}/accessToken' removed or restructured?
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L409:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupstorageconfig/vaultstorageconfig' removed or restructured?
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L495:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupFabrics/{fabricName}/protectionContainers/{containerName}/protectedItems/{protectedItemName}/recoveryPoints/' removed or restructured?
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L638:5
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupProtectedItems/' removed or restructured?
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L715:5
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AADProperties' removed or renamed?
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4522:3
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L779:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AADPropertiesResource' removed or renamed?
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4522:3
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L779:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CrrJobRequest' removed or renamed?
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4522:3
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L779:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CrossRegionRestoreRequest' removed or renamed?
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4522:3
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L779:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CrrAccessToken' removed or renamed?
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4522:3
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L779:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'OperationStatusRecoveryPointExtendedInfo' removed or renamed?
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4522:3
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L779:3
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'WorkloadCrrAccessToken' removed or renamed?
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4522:3
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L779:3
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4889:9
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1058:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4893:9
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1063:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4898:9
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1069:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4902:9
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1074:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6016:9
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1989:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6021:9
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1995:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6016:9
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1989:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6021:9
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1995:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6016:9
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1989:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6021:9
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1995:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6016:9
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1989:9
    ❌ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6021:9
    Old: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1995:9


    The following breaking changes are detected by comparison with latest preview version:

    Rule Message
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L784:13
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L641:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L12432:11
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L11578:11
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4345:13
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4001:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4394:13
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4050:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L12406:5
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L11553:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4604:9
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L4239:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6039:11
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L5581:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6039:11
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L5581:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6039:11
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L5581:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6039:11
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L5581:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6039:11
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L5581:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L6039:11
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L5581:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L7182:11
    Old: Microsoft.RecoveryServices/preview/2021-02-01-preview/bms.json#L6530:11
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 6, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⌛SDK Breaking Change Tracking pending [Detail]
    ️❌ azure-sdk-for-net failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-java warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-js warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @arpja, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    This was referenced Jan 6, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 6, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @arpja your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @arpja arpja added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 7, 2022
    @arpja
    Copy link
    Contributor Author

    arpja commented Jan 7, 2022

    Working on getting the ARM manifest updated, I have added the 'DoNotMerge' tag until then.

    Cross-Version Breaking Changes is failing since the previous version 2021-11-15 was for our Passive stamps and hence has difference in APIs. For this PR 2021-10-01 is the base version on which I have made the changes.

    @arpja arpja removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 12, 2022
    @jorgecotillo jorgecotillo added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 12, 2022
    @arpja
    Copy link
    Contributor Author

    arpja commented Jan 18, 2022

    Cross-Version Breaking Changes is failing since the previous version 2021-11-15 was for our Passive stamps and hence has difference in APIs. For this PR 2021-10-01 is the base version on which I have made the changes.

    Hi @jianyexi
    Cross-Version Breaking Changes is failing since the previous version 2021-11-15 was for our Passive stamps and hence has different in APIs. For this PR 2021-10-01 is the base version on which I have made the changes.

    @arpja
    Copy link
    Contributor Author

    arpja commented Jan 18, 2022

    @arpja , can you fix the semanticValidation errors?

    Hi @raych1

    I have fixed the Semantic validation failures.
    Please approve/merge if it looks good now.

    @arpja
    Copy link
    Contributor Author

    arpja commented Jan 19, 2022

    there are a lot of breaking changes comparing with https://github.com/Azure/azure-rest-api-specs/blob/main/specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-11-15/bms.json , could you confirm if the your change is breaking your customer ?

    Hi @jianyexi
    2021-11-15 is part of a different package but due to pipeline limitation, it is being picked up as the base version.
    The actual base version for this package is supposed to be 2021-10-01.
    Requesting to review the PR.

    @jianyexi
    Copy link
    Contributor

    After compared with https://github.com/Azure/azure-rest-api-specs/blob/main/specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-10-01/bms.json ,there is no breaking change , so

    pratimaupadhyay02
    pratimaupadhyay02 reviewed Jan 20, 2022
    View reviewed changes
    Copy link
    Contributor

    @pratimaupadhyay02 pratimaupadhyay02 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Please update readme.python.md file as well

    @jianyexi jianyexi merged commit 830d630 into Azure:main Jan 20, 2022
    This was referenced Jan 20, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    @anjorsh anjorsh mentioned this pull request Jan 26, 2022
    Merged
    25 tasks
    mstrisoline pushed a commit to mstrisoline/azure-rest-api-specs that referenced this pull request Feb 1, 2022
    @arpja @mstrisoline
    [Hub Generated] Review request for Microsoft.RecoveryServices to add …
    3ee5499 
    …version stable/2021-12-01 (Azure#17271)

* Adds base for updating Microsoft.RecoveryServices from version stable/2021-10-01 to version 2021-12-01

* Updates readme

* Updates API version in new specs and examples

* - Adding support for creation of new 'Enhanced' policy for IaaSVM backup
- This policy type will additionally support hourly backups along with daily and weekly supported by current policy
- Added respective examples for create/update, Get and List policy api

* - prettier fixes

* updating readme.md to new api

* - correcting the path of new example files

* - fixing examples

* - more fixes in examples

* fixing spell check error

* fixing semantic errors

* - semantic errors fix
    @arpja arpja mentioned this pull request Feb 11, 2022
    Merged
    25 tasks
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 15, 2022
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    @arpja @LeiWang3
    [Hub Generated] Review request for Microsoft.RecoveryServices to add …
    16ea0cb 
    …version stable/2021-12-01 (Azure#17271)

* Adds base for updating Microsoft.RecoveryServices from version stable/2021-10-01 to version 2021-12-01

* Updates readme

* Updates API version in new specs and examples

* - Adding support for creation of new 'Enhanced' policy for IaaSVM backup
- This policy type will additionally support hourly backups along with daily and weekly supported by current policy
- Added respective examples for create/update, Get and List policy api

* - prettier fixes

* updating readme.md to new api

* - correcting the path of new example files

* - fixing examples

* - more fixes in examples

* fixing spell check error

* fixing semantic errors

* - semantic errors fix
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @pratimaupadhyay02 pratimaupadhyay02 pratimaupadhyay02 approved these changes

    @jianyexi jianyexi jianyexi approved these changes

    Assignees

    @jianyexi jianyexi

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go-V2 CI-FixRequiredOnFailure
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @arpja @raych1 @jianyexi @pratimaupadhyay02 @JeffreyRichter @jorgecotillo